Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Euros a problem #7

Closed
andersonimes opened this issue Dec 10, 2024 · 13 comments · Fixed by #8
Closed

Euros a problem #7

andersonimes opened this issue Dec 10, 2024 · 13 comments · Fixed by #8
Labels

Comments

@andersonimes
Copy link

Hello! I am getting the following error trying to process a file. I'm wondering if maybe this isn't designed to process a file with Euros, maybe? Here is the error:

ValueError: could not convert string to float: '€2656'

Screenshot 2024-12-10 at 1 43 44 PM
@andersonimes
Copy link
Author

Oh. I think I know why. The values are all denoted with commas for decimals.

"€26,56"

Can you fix it or should I just regex the files before using the tool?

@andersonimes
Copy link
Author

Nope - that did not fix it.

ValueError: could not convert string to float: '€26.56'

Must be the euro symbol maybe, but looking at the code, there appears to be currency matching going on so I don't think I can just change it to a dollar symbol or remove it without impacting something else.

@juftin juftin closed this as completed in d2eab76 Dec 11, 2024
github-actions bot added a commit that referenced this issue Dec 11, 2024
# [v1.0.5](v1.0.4...v1.0.5) (2024-12-11)

## 🐛 Bug Fixes
- [`d2eab76`](d2eab76)  euros formatting (Issues: [`#7`](#7))

[skip ci]
@juftin
Copy link
Owner

juftin commented Dec 11, 2024

🎉 This issue has been resolved in version 1.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@juftin
Copy link
Owner

juftin commented Dec 11, 2024

Let me know if this didn't resolve the issue 🤝

exploded_totals["parsed_total"] = exploded_totals["parsed_total"].str.replace(
",", ".", regex=False
)

@andersonimes
Copy link
Author

result
Pretty much the same result.

@juftin
Copy link
Owner

juftin commented Dec 19, 2024

@andersonimes could you share a CSV with a few test records so I can debug on my end?

@juftin juftin reopened this Dec 19, 2024
@andersonimes
Copy link
Author

I hope I don't regret this :)

amazon_order_history.csv

@andersonimes
Copy link
Author

Hello! Did you get a chance to take a look at this?

@juftin
Copy link
Owner

juftin commented Jan 3, 2025

Yup, thanks for sending that! This was a tough fix but I believe I've got it. If you run into any issues try setting the LC_ALL=<your locale code> environment variable.

@juftin juftin closed this as completed in #8 Jan 3, 2025
@juftin
Copy link
Owner

juftin commented Jan 3, 2025

Let me know how the new version works 😅

@juftin
Copy link
Owner

juftin commented Jan 3, 2025

🎉 This issue has been resolved in version 1.0.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@andersonimes
Copy link
Author

This did not resolve the problem.

Image

@andersonimes
Copy link
Author

@juftin sorry to say I think you should reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants