Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in augment() and in validation dataset generation #34

Closed
wants to merge 1 commit into from

Conversation

rdrighetto
Copy link
Contributor

cryoCARE_extract_train_data.py now runs until completion with the here proposed changes (please check if they make sense). I'm now doing a full run to see if the quality issues are fixed.

cryoCARE_extract_train_data.py now runs until completion with the here proposed changes (please check if they make sense).
I'm now doing a full run to see if the quality issues are fixed.
@rdrighetto rdrighetto mentioned this pull request Oct 5, 2022
@tibuch
Copy link
Collaborator

tibuch commented Oct 5, 2022

Oh, I see. Is your sample_shape the same in all dimensions?

We have to be careful to only rotate around the tilt-axis.

@rdrighetto
Copy link
Contributor Author

Just to answer here: yes, in our case sample_shape is always cubic and tilt axis is always Y, but I understand the code needs to be robust to deal with cases that differ from that. Thanks for the new fix -- I will report on that soon!

@tibuch tibuch deleted the branch juglab:fix-quality-issues October 6, 2022 06:36
@tibuch tibuch closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants