Add securityContext to all workloads #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #60 this PR adds template variables for the
securityContextto all workloads (Balancer, JuiceShop, Cleaner and WatchDog). This should cover all use cases.I also considered merging them into one global
securityContextvariable but this would couple the MultiJuicer and JuiceShop further and might prevent some use cases.The PR is still missing an update to the Charts Readme. It looks like it was generated by the
Readme.md.gotmpl. However, I couldn't find a any resources on how to generate the variable used: https://github.com/iteratec/multi-juicer/blob/dc4e7c1f966350746b75e4fb64ad8426a2a05300/helm/multi-juicer/README.md.gotmpl#L21