Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go-redis to support redis 7 #3233

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Feb 13, 2023

  • StringStringMapCmd -> MapStringStringCmd Ref
  • SlaveOnly -> ReplicaOnly Ref
  • *redis.Z -> redis.Z Ref

close #3223

@github-actions
Copy link

Mutate Test Report
pkg/object/object_storage_test.go-1-1: score:0.17 failed:10, passed:2, compile error:1, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4162124097/jobs/7200946125

cmd/integration_test.go-1-1: score:0.00 failed:0, passed:0, compile error:0, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4162124097/jobs/7200945321

cmd/mount_test.go-4-4: score:1.00 failed:0, passed:47, compile error:5, out of coverage:2, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4162124097/jobs/7200945983

cmd/mount_test.go-1-4: score:1.00 failed:0, passed:46, compile error:9, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4162124097/jobs/7200945451

cmd/dump_test.go-1-1: score:1.00 failed:0, passed:15, compile error:2, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4162124097/jobs/7200945105

cmd/mount_test.go-3-4: score:1.00 failed:0, passed:53, compile error:2, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4162124097/jobs/7200945798

cmd/mount_test.go-2-4: score:1.00 failed:0, passed:49, compile error:2, out of coverage:4, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4162124097/jobs/7200945607

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@codecov-commenter
Copy link

Codecov Report

Base: 55.56% // Head: 55.50% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (0aa0a51) compared to base (018b8a9).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3233      +/-   ##
==========================================
- Coverage   55.56%   55.50%   -0.06%     
==========================================
  Files         142      142              
  Lines       33140    33140              
==========================================
- Hits        18414    18395      -19     
- Misses      12783    12797      +14     
- Partials     1943     1948       +5     
Impacted Files Coverage Δ
pkg/meta/redis_lock.go 69.23% <ø> (ø)
pkg/meta/utils.go 65.00% <ø> (ø)
pkg/object/redis.go 50.54% <ø> (ø)
pkg/meta/redis.go 66.25% <75.00%> (-0.04%) ⬇️
pkg/vfs/reader.go 75.79% <0.00%> (-3.96%) ⬇️
pkg/chunk/prefetch.go 96.29% <0.00%> (-3.71%) ⬇️
pkg/vfs/handle.go 83.58% <0.00%> (-0.75%) ⬇️
pkg/meta/sql.go 58.92% <0.00%> (+0.21%) ⬆️
pkg/chunk/disk_cache.go 73.38% <0.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davies davies merged commit 8e4d306 into main Feb 14, 2023
@davies davies deleted the upgrade_go-redis_to_support_redis_7.0 branch February 14, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JuiceFS cannot use redis v7
3 participants