Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: cancel context when emptyDir failed #4389

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

jiefenghuang
Copy link
Contributor

@jiefenghuang jiefenghuang commented Jan 30, 2024

  1. change: add cancel when failed
  2. hint: does not use wg.Wait because the function call stack is too deep and mayebe block somewhere. It involves context handling in many other functions, we will strengthen the context handling of other interfaces in the future.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5879e5b) 56.06% compared to head (f264f27) 56.02%.

Files Patch % Lines
pkg/meta/utils.go 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4389      +/-   ##
==========================================
- Coverage   56.06%   56.02%   -0.05%     
==========================================
  Files         154      154              
  Lines       40068    40070       +2     
==========================================
- Hits        22465    22448      -17     
- Misses      15094    15115      +21     
+ Partials     2509     2507       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiefenghuang jiefenghuang marked this pull request as ready for review January 30, 2024 05:55
@SandyXSD SandyXSD merged commit d46d208 into juicedata:main Jan 30, 2024
26 checks passed
@jiefenghuang jiefenghuang deleted the fix/emptyDir branch April 15, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants