-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inputs for JF version and suggester label #27
Conversation
28fadb9
to
c9dff75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
I tweaked the implementation a bit, so this is good to go from my end. Note that this is a breaking change: Currently, unformatted files that are not touched by the PR will not cause the action to fail (because reviewdog can't annotate them). |
could you add a note in the README? |
We get an auto-generated changelog, right? Not sure if a note in the readme is necessary in addition to that. |
fair enough 👍 merging this now |
one sec, I'll squash the commits |
I merge with squash and merge but if you wanna remove some history sure go ahead |
This change is breaking: Unformatted files that are not part of the current PR now also cause the action to fail.
Yeah, I mainly wanted to mention the breaking nature of this in the commit message. Should be good to go now :) |
This PR adds two input arguments to the action:
version: 1.0.54
allows pinning JuliaFormatter.jl to a major, minor, or patch versionsuggestion-label: 'foo'
only shows suggestions when that label is on the PRI've also updated
setup-julia
to v2.