Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inputs for JF version and suggester label #27

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

pfitzseb
Copy link
Contributor

@pfitzseb pfitzseb commented Apr 8, 2024

This PR adds two input arguments to the action:

  • version: 1.0.54 allows pinning JuliaFormatter.jl to a major, minor, or patch version
  • suggestion-label: 'foo' only shows suggestions when that label is on the PR

I've also updated setup-julia to v2.

@pfitzseb pfitzseb closed this Apr 8, 2024
@pfitzseb pfitzseb reopened this Apr 8, 2024
@pfitzseb pfitzseb force-pushed the sp/inputs branch 12 times, most recently from 28fadb9 to c9dff75 Compare April 8, 2024 14:51
@pfitzseb pfitzseb marked this pull request as ready for review April 8, 2024 14:52
Copy link
Collaborator

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

README.md Outdated Show resolved Hide resolved
@domluna
Copy link
Collaborator

domluna commented Apr 8, 2024

@hyrodium if this looks good to you I'm happy to merge, assuming it's ready @pfitzseb

@pfitzseb
Copy link
Contributor Author

pfitzseb commented Apr 9, 2024

I tweaked the implementation a bit, so this is good to go from my end.

Note that this is a breaking change: Currently, unformatted files that are not touched by the PR will not cause the action to fail (because reviewdog can't annotate them).

@domluna
Copy link
Collaborator

domluna commented Apr 9, 2024

Note that this is a breaking change: Currently, unformatted files that are not touched by the PR will not cause the action to fail (because reviewdog can't annotate them).

could you add a note in the README?

@pfitzseb
Copy link
Contributor Author

pfitzseb commented Apr 9, 2024

We get an auto-generated changelog, right? Not sure if a note in the readme is necessary in addition to that.

@domluna
Copy link
Collaborator

domluna commented Apr 9, 2024

fair enough 👍 merging this now

@pfitzseb
Copy link
Contributor Author

pfitzseb commented Apr 9, 2024

one sec, I'll squash the commits

@domluna
Copy link
Collaborator

domluna commented Apr 9, 2024

I merge with squash and merge but if you wanna remove some history sure go ahead

This change is breaking: Unformatted files that are not part of the current PR now also cause the action to fail.
@pfitzseb
Copy link
Contributor Author

pfitzseb commented Apr 9, 2024

Yeah, I mainly wanted to mention the breaking nature of this in the commit message. Should be good to go now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants