Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass depwarn in via julia_args #135

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

SamuelBrand1
Copy link
Contributor

@SamuelBrand1 SamuelBrand1 commented Jan 21, 2025

This PR aims to fix #49 by passing the depwarn choice to julia_args when test is called. At the moment (I think), the julia process Pkg.test is called from has a flexible depwarn but the actual test process generated by that falls back to default. So the only catch on depreciation warnings is if the outer process has --depwarn=error.

PS I've follow the same pattern as other env vars being passed to julia_args argument of test.

This is passed to the test process generated by `test(...)`
@SamuelBrand1 SamuelBrand1 requested a review from a team as a code owner January 21, 2025 10:13
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8ce963b) to head (4512dd4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

action.yml Show resolved Hide resolved
@SamuelBrand1
Copy link
Contributor Author

Thats interesting because I'm seeing the same thing as the issue... i.e. dep warnings still seem to be happening. Could this be a force option from the code maintainers?

@omus
Copy link
Contributor

omus commented Jan 21, 2025

Do you have a reference to a workflow that is getting unexpected deprecation warnings/errors?

@SamuelBrand1
Copy link
Contributor Author

Hey @omus .

Here is one https://github.com/CDCgov/Rt-without-renewal/actions/runs/12877933673/job/35903139971?pr=581

Going into the julia-runtest step you can see that the julia_cmd is julia --color=yes --depwarn=no --inline=yes --project=@. -e 'include(joinpath(ENV["GITHUB_ACTION_PATH"], "test_harness.jl"))' but plenty of depreciation warnings further down.

I'm trying to move to a situation where the main testing does not do depwarn because this seems to cause significant slow down, whilst having one CI aimed at capturing dep warnings.

@omus
Copy link
Contributor

omus commented Jan 21, 2025

Thanks. I tracked the issue down to this line in Pkg.jl. According to the PR which introduced that line we need to rely on overriding that flag via julia_actions like you propose.

If you remove the --depwarn flag from action.yaml I'm good to move ahead with this.

@SamuelBrand1
Copy link
Contributor Author

@omus thanks for looking at this.

@SamuelBrand1 SamuelBrand1 requested a review from omus January 22, 2025 08:54
Copy link
Contributor

@omus omus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggested a comment for code maintainers

test_harness.jl Show resolved Hide resolved
@omus omus changed the title Issue 49: Pass depwarn arg to test process Pass depwarn in via julia_args Jan 22, 2025
@omus omus merged commit 678da69 into julia-actions:main Jan 22, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having trouble disabling depwarns.
2 participants