-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass depwarn
in via julia_args
#135
Conversation
This is passed to the test process generated by `test(...)`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 2 2
=========================================
Hits 2 2 ☔ View full report in Codecov by Sentry. |
Thats interesting because I'm seeing the same thing as the issue... i.e. dep warnings still seem to be happening. Could this be a force option from the code maintainers? |
Do you have a reference to a workflow that is getting unexpected deprecation warnings/errors? |
Hey @omus . Here is one https://github.com/CDCgov/Rt-without-renewal/actions/runs/12877933673/job/35903139971?pr=581 Going into the I'm trying to move to a situation where the main testing does not do |
Thanks. I tracked the issue down to this line in Pkg.jl. According to the PR which introduced that line we need to rely on overriding that flag via If you remove the |
@omus thanks for looking at this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I suggested a comment for code maintainers
depwarn
arg to test processdepwarn
in via julia_args
This PR aims to fix #49 by passing the
depwarn
choice tojulia_args
whentest
is called. At the moment (I think), the julia processPkg.test
is called from has a flexibledepwarn
but the actual test process generated by that falls back to default. So the only catch on depreciation warnings is if the outer process has--depwarn=error
.PS I've follow the same pattern as other env vars being passed to
julia_args
argument oftest
.