Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to Core.TypeofVararg as typeof(Vararg) #205

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Refer to Core.TypeofVararg as typeof(Vararg) #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/faketypes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ end

function FakeTypeName(@nospecialize(x); justname=false)
@static if !(Vararg isa Type)
x isa Core.TypeofVararg && return FakeTypeofVararg(x)
x isa typeof(Vararg) && return FakeTypeofVararg(x)
end
if x isa DataType
xname = x.name
Expand Down Expand Up @@ -132,7 +132,7 @@ Base.:(==)(a::FakeTypeofBottom, b::FakeTypeofBottom) = true
FakeTypeofVararg(T) = (new(T))
FakeTypeofVararg(T, N) = new(T, N)
end
function FakeTypeofVararg(va::Core.TypeofVararg)
function FakeTypeofVararg(va::typeof(Vararg))
if isdefined(va, :N)
vaN = va.N isa TypeVar ? FakeTypeVar(va.N) : va.N
FakeTypeofVararg(FakeTypeName(va.T; justname=true), vaN) # This should be FakeTypeName(va.N) but seems to crash inference.
Expand Down