Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing on FREEAPS Loop #1

Closed
miki3421 opened this issue May 30, 2020 · 19 comments
Closed

Installing on FREEAPS Loop #1

miki3421 opened this issue May 30, 2020 · 19 comments
Labels
done

Comments

@miki3421
Copy link

Hi, I tried to install on the FreeAps version of Loop

https://github.com/ivalkou/LoopWorkspace

and It's able to run only if the app is not installed yet.
The second time is crashing with the message.

EXC_BAD_ACCESS

attached you can find a detailed error.
Thanks

Screenshot 2020-05-30 at 18 26 34
@julian-groen
Copy link
Owner

Hi, I looked into it and couldn't find any connection with this client. As of now the only thing I can think of is that the FreeAps uses a different App Group identifier. Correct me if I'm wrong cuz im not familiar with this version of Loop.

Feel free to contact me if you still get an error.

@miki3421
Copy link
Author

miki3421 commented Jun 1, 2020 via email

@miki3421
Copy link
Author

miki3421 commented Jun 1, 2020 via email •
edited
Loading

@julian-groen
Copy link
Owner

Hi, I looked into it and didn't get any errors. The other error isn't really important if the main app of xdrip wil support those schemes it will work just fine. For the EXC_BAD_ACCESS error I think you have to look deeper into other dependencies cuz this client is just a framework and wil not mess with internal loop code like the one you showed me.

Hope you will find a solution to the problem if you need anything just contact me

@miki3421
Copy link
Author

miki3421 commented Jun 1, 2020 via email

@julian-groen
Copy link
Owner

I will try. If you remove the client this error doesn't acquire?

@miki3421
Copy link
Author

miki3421 commented Jun 3, 2020 •
edited
Loading

No if you remove the client one time is setup you can't do the rollback.
You need to download again and recompile.
For my tests I'm keeping two separate folders.

did you reproduce the issue?

@julian-groen
Copy link
Owner

Alright, no everything kept working for me maybe try to reinstall everything?
If this error keeps happening please commit it to git so I can clone your setup.

@miki3421
Copy link
Author

miki3421 commented Jun 8, 2020

I tried .. nothing changed.
How i can commit to git? Sorry but I'm not so expert in the matter of development.
I tried to fork the Workspace but it's not tracing the changes in Loop folder. Do I need to create a separate Repository?

@julian-groen
Copy link
Owner

Try to google it, kinda hard to explain by text. You should also be able to just commit to the fork repo.

@miki3421
Copy link
Author

Hi @julian-groen thanks for your response.
I tried to create https://github.com/miki3421/FREEAPS-with-Xdrip-Client with all folder of the project. However when I'm building the app I'm receiving this error.

Gathering build details in /Users/mm/Documents/GitHub/FREEAPS-xdrip/FREEAPS-with-Xdrip-Client/Loop
fatal: not a git repository: /Users/mm/Documents/GitHub/FREEAPS-xdrip/FREEAPS-with-Xdrip-Client/Loop/../.git/modules/Loop
Command PhaseScriptExecution failed with a nonzero exit code

any ideas?

@julian-groen
Copy link
Owner

Can you send me a message on gitter.im?

@miki3421
Copy link
Author

miki3421 commented Jun 10, 2020 via email

@clvsjr9
Copy link

clvsjr9 commented Jun 18, 2020 •
edited
Loading

Hello,

Some minor adjustments needs to be done in Info.plist files of: FreeAPS and xdripswift projects to be possible to click on BG value of HUD of Loop and then open xDrip app.

On xdripswift Project this is necessary: (Tell to Mr. Johan to do this minor detail)

xdrip-Info

On FreeAPS Project this is necessary: (Julian, could you update the Readme file with a new paragraph on: Add xDrip as a CGM source to Loop in Xcode to complete?)

Loop Info

@julian-groen
Copy link
Owner

@clvsjr9 Thanks, I added the url scheme to the appUrl variable just as a placeholder no further intentions. So maybe they will add this feature in any further releases of xdrip.

@miki3421 Did you manage to solve the issue?

@clvsjr9 clvsjr9 mentioned this issue Jun 18, 2020
Closed
@miki3421
Copy link
Author

@julian-groen I've applied boths changes but the issue still present.
When FREEAPS is starting is crashing, if is not connected to Xdrip Debugger.

@JohanDegraeve
Copy link

Hi, are you still waiting on a change in xdripswift ?

@julian-groen
Copy link
Owner

@JohanDegraeve no, not really. I just placed a placeholder for an appurl to xdrip nothing special there but there seems to be an bug with this FreeAPS version of Loop. I tried to look into it but couldn't find anything related with this client. So my advice to @miki3421 still would be to contact the developers of this FreeAPS version in order to fix it. If @miki3421 not already solved it himself.

@julian-groen
Copy link
Owner

@miki3421 I looked into the code of the normal version of Loop and found the exact same code. This client is running perfectly fine on my device for a couple of months. So in order to fix your issue I think you should update the FreeAPS code or move to a newer version of iOS. If this all doesn't work try to contact the FreeAPS Loop developers cause I still am 99% sure this issue isn't produced by this client.

Best of Luck!

4gra added a commit to 4gra/xdripswift that referenced this issue Mar 25, 2021
@4gra
Grant xdrip its own URL scheme
a727b95 
This allows shortcut-opening the application from within Loop.app
as per JohanDegraeve#116
   and julian-groen/xdrip-client-swift#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clvsjr9 @JohanDegraeve @miki3421 @julian-groen