This repository has been archived by the owner on Mar 14, 2020. It is now read-only.
fixes react StrictMode deprecation warnings #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks. But I think this version of library won't work with React 17 anyway. It have to be totally rewritten using new approaches in React introduced in newest versions. And this needs more tests before publishing it. |
|
We can't be sure this library will work or not with React 17, but at least with this PR, there is no more any warnings. As far as the tests are concerned, I was unable to run tests without error. It seems there is an already referenced issue about it (#54 ). |
|
Yes, I meant manual tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library with the latest version of React with StrictMode enabled, two different warning are generated:
componentWillMountwill be removed in React 17 and should no more be used.ReactDOM.findDOMNodewill be removed in React 17 and should no more be used.This PR just follows the official React documentation (here and here) to fix these warnings.