Fix false number recomposing and NaN number problem #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems.
Fix One
When animating numbers of a path or other number series and the numbers may change from a positive to a negative value, like in the following example, the recomposing of the number string will be wrong.
The problem results in the fact, that the returned string will be recomposed from the
tween.to.string
array, but the shortest form in asvg
image can be no space (separator) but a negative number. So the string array will have '' and when the from number is still positive there is no separator to the following number.Here is an example of how it will look like:
https://codepen.io/anon/pen/xdvjOM
And here how it will look with my fix:
https://codepen.io/anon/pen/EmqBNv
Second fix
This will avoid the returning of NaN numbers. It will also fix the issue in #167 and maybe #119 and #164.
The problem is that if the length of the
tween.from.number
array is lower than thetween.to.number
array, the value calculation try to calculate with a non existing array value which then results in NaN. So we have to use at least a 0 when calculating.