fix: fix lint

juliangsibecas · Sep 8, 2024 · 52f831f · 52f831f
1 parent 6fcb7fb
commit 52f831f
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -7,7 +7,6 @@
     "@nx/devkit": "19.6.5",
     "@nx/jest": "19.6.5",
     "@nx/js": "19.6.5",
-    "@types/js-yaml": "^4.0.9",
     "ignore": "^5.3.2",
     "js-yaml": "^4.1.0",
     "nx": "19.6.5",
@@ -23,6 +22,7 @@
     "@swc/core": "~1.5.7",
     "@swc/helpers": "~0.5.11",
     "@types/jest": "^29.5.12",
+    "@types/js-yaml": "^4.0.9",
     "@types/node": "18.16.9",
     "@typescript-eslint/eslint-plugin": "^7.16.0",
     "@typescript-eslint/parser": "^7.16.0",

diff --git a/src/generators/init/generator.ts b/src/generators/init/generator.ts
@@ -1,5 +1,6 @@
 import { formatFiles, readNxJson, Tree, updateNxJson } from '@nx/devkit';
 import { addGitIgnoreEntry } from '../../utils';
+import { addGithubActionCI } from 'src/utils/add-github-action-ci';
 
 export async function initGenerator(tree: Tree) {
   const nxJson = readNxJson(tree) || {};
@@ -31,6 +32,7 @@ export async function initGenerator(tree: Tree) {
   updateNxJson(tree, nxJson);
 
   addGitIgnoreEntry(tree);
+  addGithubActionCI(tree);
 
   await formatFiles(tree);
 }

diff --git a/src/utils/add-github-action-ci.spec.ts b/src/utils/add-github-action-ci.spec.ts
@@ -1,5 +1,5 @@
 import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing';
-import { Tree, readNxJson } from '@nx/devkit';
+import { Tree } from '@nx/devkit';
 
 import { addGithubActionCI } from './add-github-action-ci';
 

diff --git a/src/utils/add-github-action-ci.ts b/src/utils/add-github-action-ci.ts
@@ -3,14 +3,25 @@ import * as yaml from 'js-yaml';
 
 const CI_FILE_PATH = '.github/workflows/ci.yml';
 
+type YamlFile = {
+  name: string;
+  jobs: {
+    main: {
+      steps: Array<{
+        uses: string;
+        name?: string;
+        with?: Record<string, string>;
+      }>;
+    };
+  };
+};
+
 export const addGithubActionCI = async (host: Tree) => {
   if (!host.exists('.github/workflows/ci.yml')) {
     return;
   }
 
-  let file: Record<string, any> = await yaml.load(
-    host.read(CI_FILE_PATH, 'utf8'),
-  );
+  const file = (await yaml.load(host.read(CI_FILE_PATH, 'utf8'))) as YamlFile;
 
   const actionStep = file.jobs.main.steps.findIndex(
     ({ uses }) => uses === 'actions/checkout@v4',