Optimize InstantRunOff #2

julien-boudry · May 22, 2021 · dec56a0 · dec56a0
1 parent 7277660
commit dec56a0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/Algo/Methods/InstantRunoff/InstantRunoff.php b/lib/Algo/Methods/InstantRunoff/InstantRunoff.php
@@ -123,8 +123,8 @@ protected function makeScore (array $candidateDone) : array
                 foreach ($oneRank as $oneCandidate) :
                     if (\count($oneRank) !== 1) :
                         break;
-                    elseif (!\in_array(needle: $this->_selfElection->getCandidateKey($oneCandidate), haystack: $candidateDone, strict: true)) :
-                        $score[$this->_selfElection->getCandidateKey($oneRank[\array_key_first($oneRank)])] += $weight;
+                    elseif (!\in_array(needle: ($candidateKey = $this->_selfElection->getCandidateKey($oneCandidate)), haystack: $candidateDone, strict: true)) :
+                        $score[$candidateKey] += $weight;
                         break 2;
                     endif;
                 endforeach;