-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up authenticate() into individual actions to allow per-action use #436
base: master
Are you sure you want to change the base?
Split up authenticate() into individual actions to allow per-action use #436
Conversation
… approach or an approach where more control is required and underlaying actions need to be called seperately
Thanks for this PR! Overall I think this is a nice improvement that enables more extensibility. This change also adds the ability to use specific I noticed that the updated code has tabs instead of spaces, mabye you can update the code to use spaces. |
@ricklambrechts Thanks for the feedback and sorry about the tabs, will correct those |
typo Co-authored-by: Rick Lambrechts <[email protected]>
Hi @ricklambrechts do you have an idea whether this change will be adopted? Or whom to nudge? |
@DeepDiver1975 Would you be interested in reviewing this PR? |
Second this, could we get this reviewed ? |
Allowing the caller to call the magical request handler
authenticate
or
to have more control over the process and call the individual actions themself
requestAuthorization
,handleCode
,handleClaims
)authenticate()
makes use of newly created atomic actions