Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up authenticate() into individual actions to allow per-action use #436

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bartgloudemans
Copy link

@bartgloudemans bartgloudemans commented Sep 12, 2024

Allowing the caller to call the magical request handler authenticate
or
to have more control over the process and call the individual actions themself

  • Added public methods per action (requestAuthorization, handleCode, handleClaims)
  • authenticate() makes use of newly created atomic actions

… approach or an approach where more control is required and underlaying actions need to be called seperately
@bartgloudemans bartgloudemans changed the title Split up interface to allow per action use Split up authenticate() into individual actions to allow per-action use Sep 12, 2024
@bartgloudemans bartgloudemans marked this pull request as ready for review September 16, 2024 09:56
@bartgloudemans bartgloudemans marked this pull request as draft September 16, 2024 10:10
@bartgloudemans bartgloudemans marked this pull request as ready for review September 16, 2024 10:53
README.md Outdated Show resolved Hide resolved
@ricklambrechts
Copy link
Contributor

ricklambrechts commented Sep 16, 2024

Thanks for this PR! Overall I think this is a nice improvement that enables more extensibility.

This change also adds the ability to use specific $_GET or $_POST params instead of the $_REQUEST param by just overriding the updated authenticate function.

I noticed that the updated code has tabs instead of spaces, mabye you can update the code to use spaces.

@bartgloudemans
Copy link
Author

@ricklambrechts Thanks for the feedback and sorry about the tabs, will correct those

bartgloudemans and others added 3 commits September 16, 2024 15:35
@bartgloudemans
Copy link
Author

Hi @ricklambrechts do you have an idea whether this change will be adopted? Or whom to nudge?
We're investigating what dependency to use to enable OIDC, and a split up interface would make this package fit us better.
Kind regards

@bartgloudemans
Copy link
Author

@DeepDiver1975 Would you be interested in reviewing this PR?

@ekarlso
Copy link

ekarlso commented Dec 30, 2024

Second this, could we get this reviewed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants