Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all atom files into a single-level directory layout #609

Merged
merged 1 commit into from
May 2, 2024

Conversation

odow
Copy link
Member

@odow odow commented May 2, 2024

Now that we can support arbitrary MOI sets, and we aim to move as much of the complexity to MOI as possible, including various bridge reformulations, it doesn't really make sense to talk about exp_cone atoms or second_order_cone atoms. (Consider the GeoMeanAtom, which can have a SOCP or PowerCone formulation.)

This PR moves everything to src/atoms/FooBarAtom.jl.

Longer term, I want to better document each atom, and provide a way of searching for various atoms that you can use.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (cc6a9b0) to head (762e917).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          88       88           
  Lines        5066     5066           
=======================================
  Hits         4957     4957           
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 197e15f into master May 2, 2024
9 of 10 checks passed
@odow odow deleted the od/atom-layout branch May 2, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants