Test conic forms for constant values #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 97.75% 97.79% +0.04%
==========================================
Files 88 88
Lines 5073 5075 +2
==========================================
+ Hits 4959 4963 +4
+ Misses 114 112 -2 ☔ View full report in Codecov by Sentry. |
57 tasks
odow
reviewed
May 5, 2024
odow
reviewed
May 5, 2024
|
Okay. I've simplified the test handling, but now it requires #623 |
|
Urgh. I borked that. Let's just wait and I'll rebase on |
odow
reviewed
May 5, 2024
| context = Convex.Context{value_type}(MOI.Utilities.Model{value_type}) | ||
| atom = _to_constant(build_fn(context)) | ||
| if Convex.iscomplex(atom) || any(Convex.iscomplex, atom.children) | ||
| return |
odow
approved these changes
May 5, 2024
This was referenced May 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #616 in the real case only. In the complex case unfortunately I found many issues, too many to address in this PR. Some would be addressed similarly to the change for
new_conic_form!(context::Context{T}, e::RelativeEntropyAtom), whereGenericConstraintnicely handles the constant case, but directMOI_add_constraintdoes not.(The issues here are not really correctness bugs, but rather errors one would get if for some reason they had constant values rather than variables in some atoms, such as if you
fix!'d a variable).