-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gurobipy license file from conda downloads #3
Conversation
@odow I couldn't see an obvious way to strip files out as an artifact is downloaded, but force-deleting the gurobi.lic files at import time seems to do the trick. Does that seem reasonable, or is there a better approach? |
This seems okay. I just pushed a commit to test using the (undocumented) global constant I'm not sure what the consequence of modifying an artifact like this is. They're usually meant to be immutable, so the package manager might re-download the artifact it it notices the SHA doesn't match? Or perhaps once unpacked, it never re-verifies. (The SHA is the directory name, so it might just check if the folder exists.) |
Thanks. In my testing of it so far, it seems to just unpack once and never verify later (I suppose it could be expensive to verify on every import). But I couldn't find any clear statement in the docs re: when or if this is re-checked. |
The conda packages include a license file which will only work from Python. So currently, if the user does not have a Gurobi license on their machine, they'll get a confusing error message:
This PR is to delete the license file in the extracted artifact dir so that we get a more sensible message: