Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests adding multiple variable bounds #434

Merged
merged 2 commits into from
Jul 29, 2018
Merged

Fix tests adding multiple variable bounds #434

merged 2 commits into from
Jul 29, 2018

Conversation

odow
Copy link
Member

@odow odow commented Jul 28, 2018

To fix orderedindices test, we use different variables.
Closes #403

To fix the basic_constraint_tests, we skip the test that addconstraints! works for SingleVariable-in-Set constraints.
Closes #404

@codecov-io
Copy link

codecov-io commented Jul 28, 2018

Codecov Report

Merging #434 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   95.68%   95.69%   +<.01%     
==========================================
  Files          40       40              
  Lines        5242     5244       +2     
==========================================
+ Hits         5016     5018       +2     
  Misses        226      226
Impacted Files Coverage Δ
src/Test/UnitTests/basic_constraint_tests.jl 98.33% <100%> (ø) ⬆️
src/Test/modellike.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6ec23...0cce177. Read the comment docs.

@odow odow changed the title Stop adding multiple SingleVariable-in-Set constraints in the unit tests Fix tests adding multiple variable bounds Jul 28, 2018
@odow odow merged commit cdb6d1a into master Jul 29, 2018
@odow odow deleted the odow/fixtests branch July 29, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix constraints units tests for SingleVariable in Set Fix orderedindicestest
3 participants