Fix #133, remove_constraints!(opt) doesn't work; chkn() not defined #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for issue #133
Purpose
The purpose of this pull request is to fix issue #133. Currently,
remove_constraints!(opt)
produces the following error:The problem is that there is no function named
chkn
.Proposal
It appears that the intention of the missing function is to check for any errors thrown by NLopt. The function
chk
already does this. Therefore, I have simply redefinedremove_constraints!
to usechk
instead ofchkn
.Additional Notes
I have also included a test file,
fix133.jl
, where I testremove_constraints!(::Opt)
.Please note that I'm not a Julia expert and this is my first ever pull request. So, I'm not too sure whether I've done this PR thing correctly. Any constructive feedback will be much appreciated.