Split "plot_tree" phases #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jr-nicola
reviewed
Nov 8, 2022
jr-nicola
reviewed
Nov 8, 2022
russHyde
force-pushed
the
split-plot-tree-phases
branch
from
d630c3c to
75f0a75
Compare
|
@jr-nicola I've bumped the version of the package now. Could you approve please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim: simplify the definition / saving of the tree images in
treeview()function.The tree images are created by the
.plot_tree()inner function. But, sinceplot_treedepended on a lot of variables in thetreeview()scope, it wasn't easy to pullplot_tree()out in one go..plot_tree()had a few separate stages: The creation of a non-interactive ggtree object, the creation of an interactive ggtree object, the conversion of the latter into an htmlwidget, and the saving of some of these objects.The changes here (which build upon #6 ) extract those inner phases of
.plot_treeand all variables used by the new functions are passed in as arguments, to isolate them from the plot_view scope.A further PR, where
plot_treeis separated into the steps that make the tree objects, and the steps that save them, and extract those functions from theplot_treescope builds upon this in [TODO]