perf: use spinner for waiting (#1618) #1620
Conversation
--------- Co-authored-by: Eric <[email protected]>
| @@ -633,7 +636,8 @@ func (p *Parser) waitCommandConfirm() { | |||
| return | |||
| default: | |||
| delayS := fmt.Sprintf("%ds", delay) | |||
| data := strings.Repeat("\x08", len(delayS)+len(waitMsg)) + waitMsg + delayS | |||
| currentSpinner := spinner[delay%len(spinner)] | |||
| data := strings.Repeat("\x08", len(delayS)+len(currentSpinner)) + currentSpinner + delayS | |||
| p.srvOutputChan <- []byte(data) | |||
| time.Sleep(time.Second) | |||
| delay += 1 | |||
There was a problem hiding this comment.
There is no difference between these two codes. They seem to be identical except for a change in the "waitCmdConfirm" variable name ("cmdWait") which could potentially cause issues with global variables if it's defined elsewhere.
Both of them look clean, well-commented and efficient without major changes needed on my end, they should work fine according to their functions described here:
- waits till a confirmation command from user
- can then proceed after getting this confirmation
No major optimizations suggested, but maybe more detailed comments/clarifications on what exactly each function needs/wants to achieve would give better insight into why this works as intended. This doesn't impact the functionality though so no need to worry about that. Just keep things clear and maintainable for long term use!
|
perf: use spinner for waiting (#1618) --------- Co-authored-by: Eric [email protected]