Fix bin/fzf-preview.sh to make image preview work on ghostty terminal #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide more details? |
|
Hi, sorry for the lack of details. I have edited to include more. I hope it's better |
Coko7
changed the title
junegunn
reviewed
Feb 9, 2025
… icat rather than kitty icat (works with ghostty)
junegunn
reviewed
Feb 9, 2025
|
Merged, thanks! |
|
You are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bin/fzf-preview.sh so that image preview works on ghostty terminal.
Issue
Despite ghostty supporting the Kitten graphics protocol, the image preview does not work even if
kittenis installed on the system because the script only checks for theKITTY_WINDOW_IDenvironment variable, which is unset in ghostty terminal sessions.So, when trying to preview images in ghostty, it merely prints the file type:
Solution
Check if
kittenis installed on the system usingcommand -v kitten.See: https://sw.kovidgoyal.net/kitty/kittens_intro/