Resolve syntax highlighting group in neovim/treesitter #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junegunn
reviewed
Apr 8, 2024
junegunn
reviewed
Apr 8, 2024
junegunn
reviewed
Apr 8, 2024
junegunn
reviewed
Apr 8, 2024
To prepare a place for the future complexity that can be reused.
junegunn
reviewed
Apr 11, 2024
|
I hope everything is OK now :) |
* Remove line-number only example that is not going to be very useful * Use get() to simplify the code * Use lowercase dictionary keys for consistency
|
Thanks, merged it with a few small changes. I haven't actually tested the Neovim part as I'm not a Neovim user, I just hope it works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the SUBJ says, it should now detect the highlighting group even when the syntax highlighting is managed by treesitter in neovim. This should partially address #159
Also, I moved the highlighting detection logic into a separate function, and added end-user interface for it - now it is possible to detect the highlighting group name (or the absence of such) for any position in a file. This possibility exists as vim function only - I deliberately decided against creating command binding for it. This is a debug functionality, I'd rather prefer it not to show up in command completion.