Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): respect floating point numbers in svg viewbox, width and height attributes #49

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix(core): respect floating point numbers in svg viewbox, width and height attributes #49

merged 1 commit into from
Dec 7, 2022

Conversation

bezoerb
Copy link
Member

@bezoerb bezoerb commented Dec 6, 2022

Fixes #47 and #6

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sebil
sebil approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@sebil sebil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of square brackets 😵‍💫 LGTM!

@bezoerb bezoerb merged commit b4fee92 into main Dec 7, 2022
@bezoerb bezoerb deleted the fix-floating-point-svg-issue branch December 7, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebil sebil sebil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect and allow decimal points in .svg viewboxes
2 participants
@bezoerb @sebil