[About] [Dashboard] move GitHub button from Dashboard to About

junhaoliao · Dec 28, 2022 · 6f0eb50 · 6f0eb50
1 parent 2fa1beb
commit 6f0eb50
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 25 deletions.
diff --git a/client/src/interface/components/About/index.js b/client/src/interface/components/About/index.js
@@ -50,6 +50,8 @@ import LinkForNewWindow from '../LinkToNewWindow';
 import iCtrlQRCode from './iCtrlQRCode.svg';
 import './index.css';
 import ICtrlVoiceButton from '../iCtrlVoiceButton/iCtrlVoiceButton';
+import GitHubButton from 'react-github-btn';
+import {openInNewWindow} from '../../../actions/utils';
 
 const AboutSection = (props) => (
     <>
@@ -90,8 +92,29 @@ export default class About extends React.Component {
     return <Dialog open={true} fullWidth={true} maxWidth={'md'}>
       <DialogTitle>
         <div style={{display: 'flex', alignItems: 'center'}}>
-          <span>About iCtrl {version && `(v${version})`}</span>
-          <ICtrlVoiceButton/>
+          <div style={{flexGrow: 1, display: 'flex', alignItems: 'center'}}>
+            <span style={{
+              marginLeft: '16px',
+              marginRight: '8px',
+              fontWeight: 'bold',
+              fontSize: '24px',
+            }}>About iCtrl {version && `(v${version})`}</span>
+            <ICtrlVoiceButton/>
+          </div>
+          <div onClick={(ev) => {
+            openInNewWindow(
+                'https://github.com/junhaoliao/iCtrl', ev);
+          }}>
+            <GitHubButton
+                href="https://github.com/junhaoliao/iCtrl"
+                data-color-scheme="no-preference: light_high_contrast; light: light_high_contrast; dark: light_high_contrast;"
+                data-show-count="true"
+                aria-label="Star junhaoliao/iCtrl on GitHub"
+                data-size={'large'}
+            >
+              Star
+            </GitHubButton>
+          </div>
         </div>
       </DialogTitle>
       <DialogContent style={{maxHeight: '630px'}}>

diff --git a/client/src/interface/pages/Dashboard/index.js b/client/src/interface/pages/Dashboard/index.js
@@ -42,9 +42,7 @@ import axios from 'axios';
 
 import logo from '../../../icons/logo.webp';
 import ictrlLogo from '../../../icons/logo.webp';
-import {openInNewWindow} from '../../../actions/utils';
 import About from '../../components/About';
-import GitHubButton from 'react-github-btn';
 import ResetVNCDialog from '../../components/ResetVNCDialog';
 import TrafficLights from '../../components/TrafficLights/TrafficLights';
 import Session from './Session';
@@ -177,28 +175,10 @@ export default class Dashboard extends React.Component {
                           sx={{flexGrow: 1}}>
                 iCtrl Dashboard
               </Typography>
-              <div
-                  className={'titlebar-buttons'}
-                  onClick={(ev) => {
-                    openInNewWindow(
-                        'https://github.com/junhaoliao/iCtrl', ev);
-                  }}
-                  style={{
-                    marginTop: '5px',
-                    marginRight: '16px',
-                    overflowX: 'auto',
-                    overflowY: 'hidden',
-                  }}>
-                <GitHubButton
-                    href="https://github.com/junhaoliao/iCtrl"
-                    data-color-scheme="no-preference: light_high_contrast; light: light_high_contrast; dark: light_high_contrast;"
-                    data-show-count="true"
-                    aria-label="Star junhaoliao/iCtrl on GitHub">Star</GitHubButton>
-
-              </div>
               <Tooltip title="About iCtrl"
                        className={'titlebar-buttons'}>
-                <IconButton onClick={this.handleAboutOpen}
+                <IconButton disabled={loading_sessions}
+                            onClick={this.handleAboutOpen}
                             size={'large'}>
                   <InfoIcon style={{color: 'white'}}
                             fontSize="large"/>
@@ -282,5 +262,4 @@ export default class Dashboard extends React.Component {
         </>
     );
   }
-
 }