Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the download badge #23

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Add the download badge #23

merged 2 commits into from
Aug 27, 2023

Conversation

Leo6Leo
Copy link
Collaborator

@Leo6Leo Leo6Leo commented Aug 2, 2023

No description provided.

@Leo6Leo Leo6Leo requested a review from junhaoliao August 2, 2023 05:26
@Leo6Leo
Copy link
Collaborator Author

Leo6Leo commented Aug 2, 2023

/cc @junhaoliao

Copy link
Owner

@junhaoliao junhaoliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup needed

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@junhaoliao
Copy link
Owner

Actually, why do we want to insert it as a link?

Should we use the Markdown syntax instead of the HTML one? i.e.,

[![Download Stats](https://img.shields.io/github/downloads/junhaoliao/iCtrl/total)]()

Download Stats

@Leo6Leo
Copy link
Collaborator Author

Leo6Leo commented Aug 27, 2023

/cc @junhaoliao

@Leo6Leo Leo6Leo requested a review from junhaoliao August 27, 2023 02:11
@junhaoliao junhaoliao merged commit 329de87 into main Aug 27, 2023
@Leo6Leo Leo6Leo deleted the add-the-download-badge branch August 28, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants