Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VNC passwd create & parse commands for Debian Bookworm compatibility #29

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

li-ruihao
Copy link
Contributor

The list of commands that iCtrl uses to renew passwords for the UG machines at UofT contains a command called xxd(search up on Google for the purpose). However, due to a system upgrade for the UG machines, this command is no longer available which means a password renewal would not work. This PR fixes the issue and patches the bug.

Copy link
Owner

@junhaoliao junhaoliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Please revise accordingly.

application/features/VNC.py Outdated Show resolved Hide resolved
application/features/VNC.py Outdated Show resolved Hide resolved
application/features/VNC.py Outdated Show resolved Hide resolved
application/features/VNC.py Outdated Show resolved Hide resolved
application/features/VNC.py Outdated Show resolved Hide resolved
application/routes/vnc.py Outdated Show resolved Hide resolved
application/routes/vnc.py Outdated Show resolved Hide resolved
@junhaoliao
Copy link
Owner

Shall we also update the PR title to

Update VNC passwd create & parse commands for Debian Bookworm compatibility.

@li-ruihao li-ruihao changed the title Fixed bug on UG machine password renew process due to system upgrade Update VNC passwd create & parse commands for Debian Bookworm compatibility Jul 21, 2024
@junhaoliao junhaoliao merged commit eb4b780 into junhaoliao:main Jul 22, 2024
@li-ruihao li-ruihao deleted the ICtrl_UG_Password_Renew_Bug branch July 24, 2024 02:41
xx12345798 added a commit to xx12345798/iCtrl that referenced this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants