-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VNC passwd create & parse commands for Debian Bookworm compatibility #29
Merged
junhaoliao
merged 3 commits into
junhaoliao:main
from
li-ruihao:ICtrl_UG_Password_Renew_Bug
Jul 22, 2024
Merged
Update VNC passwd create & parse commands for Debian Bookworm compatibility #29
junhaoliao
merged 3 commits into
junhaoliao:main
from
li-ruihao:ICtrl_UG_Password_Renew_Bug
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhaoliao
requested changes
Jul 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Please revise accordingly.
junhaoliao
reviewed
Jul 21, 2024
junhaoliao
reviewed
Jul 21, 2024
junhaoliao
reviewed
Jul 21, 2024
junhaoliao
reviewed
Jul 21, 2024
junhaoliao
reviewed
Jul 21, 2024
junhaoliao
reviewed
Jul 21, 2024
Shall we also update the PR title to
|
li-ruihao
changed the title
Fixed bug on UG machine password renew process due to system upgrade
Update VNC passwd create & parse commands for Debian Bookworm compatibility
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of commands that iCtrl uses to renew passwords for the UG machines at UofT contains a command called xxd(search up on Google for the purpose). However, due to a system upgrade for the UG machines, this command is no longer available which means a password renewal would not work. This PR fixes the issue and patches the bug.