Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(application): Handle logging setup failure with basic configuration. #42

Merged
merged 6 commits into from
Jan 9, 2025
Merged

fix(application): Handle logging setup failure with basic configuration. #42

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fcc2d76
Logic changes to logging initialization and configuration in applicat…
li-ruihao Dec 27, 2024
2d6129e
Added comments in application\__init__.py
li-ruihao Dec 27, 2024
74e7f21
Minor changes in application/__init__.py according to coderabbitai's …
li-ruihao Dec 27, 2024
bfb69cc
Reverted a small change in application/__init__.py, config variable i…
li-ruihao Dec 27, 2024
4b46a72
changed logging statements to use %s operators, instead of f-strings
li-ruihao Dec 27, 2024
f86f53d
Changes made to application/__init__.py based on code review
li-ruihao Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions application/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,18 @@
from werkzeug.exceptions import HTTPException
from werkzeug.serving import WSGIRequestHandler

logger = logging.getLogger(__name__)

try:
with open('log_config.yaml', 'r') as config_file:
with open('log_config.yaml') as config_file:
li-ruihao marked this conversation as resolved.
Show resolved Hide resolved
config = yaml.safe_load(config_file.read())
logging.config.dictConfig(config)
except Exception as ex:
print("Logging setup failed with exception = ", ex)

logger = logging.getLogger(__name__)
logger.warning(f"Logging is set up with config={config}")
except Exception:
# Fallback to a basic configuration
logging.basicConfig(format='%(asctime)s %(levelname)s [%(name)s:%(lineno)d] %(message)s', level=logging.INFO, force=True)
logger.exception("Logging setup failed")
else:
logger.warning("Logging setup is completed with config=%s", config)

from .Profile.Profile import Profile

Expand Down
Loading