Never reorder classes annotated with @FixMethodOrder #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
approved these changes
Nov 20, 2019
This is needed because classes annotated with @FixMethodOrder will not be reordered or sorted, so having both annotations is a contradiction. - Add AnnotationValidator to fail if class annotated with @FixMethodOrder - Annotate OrderWith with @ValidateWith(OrderWithValidator.class) - Add tests for the new validator
|
Thanks for the review, @marcphilipp I spit the commit into this pull into two (the first commit containing the changes to sorting/ordering, the second commit adding the validation check). I suggest using "Create a merge commit" (and not "Squash and merge") for this pull but it's up to you. @stefanbirkner any concerns with these changes? |
|
I'd use "Rebase and merge" which would also preserve both commits but avoid the additional merge commit. |
stefanbirkner
approved these changes
Nov 24, 2019
|
Thanks, @kcooney! Could you please add an entry to the release notes? |
|
@marcphilipp Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1637