Fix tests and improve error message

junit-team · Nov 20, 2024 · bffa0e6 · bffa0e6
1 parent 4dbd616
commit bffa0e6
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 3 deletions.
diff --git a/junit-platform-engine/src/main/java/org/junit/platform/engine/EngineDiscoveryRequest.java b/junit-platform-engine/src/main/java/org/junit/platform/engine/EngineDiscoveryRequest.java
@@ -87,6 +87,7 @@ default EngineDiscoveryListener getDiscoveryListener() {
 	}
 
 	default OutputDirectoryProvider getOutputDirectoryProvider() {
-		throw new JUnitException("OutputDirectoryProvider not available");
+		throw new JUnitException(
+			"OutputDirectoryProvider not available; probably due to unaligned versions of the junit-platform-engine and junit-platform-launcher jars on the classpath/module path.");
 	}
 }
diff --git a/platform-tooling-support-tests/projects/gradle-kotlin-extensions/build.gradle.kts b/platform-tooling-support-tests/projects/gradle-kotlin-extensions/build.gradle.kts
@@ -11,10 +11,12 @@ repositories {
 
 // grab jupiter version from system environment
 val jupiterVersion = System.getenv("JUNIT_JUPITER_VERSION")
+val platformVersion: String = System.getenv("JUNIT_PLATFORM_VERSION")
 
 dependencies {
 	testImplementation(kotlin("stdlib-jdk8"))
 	testImplementation("org.junit.jupiter:junit-jupiter:$jupiterVersion")
+	testRuntimeOnly("org.junit.platform:junit-platform-launcher:$platformVersion")
 }
 
 tasks.withType<KotlinCompile>().configureEach {

diff --git a/platform-tooling-support-tests/projects/gradle-missing-engine/build.gradle.kts b/platform-tooling-support-tests/projects/gradle-missing-engine/build.gradle.kts
@@ -31,7 +31,7 @@ dependencies {
 	testImplementation("org.junit.jupiter:junit-jupiter-api:$jupiterVersion") {
 		exclude(group = "org.junit.jupiter", module = "junit-jupiter-engine")
 	}
-}
+	testRuntimeOnly("org.junit.platform:junit-platform-launcher:$platformVersion")}
 
 tasks.test {
 	useJUnitPlatform()

diff --git a/platform-tooling-support-tests/projects/gradle-starter/build.gradle.kts b/platform-tooling-support-tests/projects/gradle-starter/build.gradle.kts
@@ -4,7 +4,6 @@ plugins {
 
 // grab jupiter version from system environment
 val jupiterVersion: String = System.getenv("JUNIT_JUPITER_VERSION")
-val vintageVersion: String = System.getenv("JUNIT_VINTAGE_VERSION")
 val platformVersion: String = System.getenv("JUNIT_PLATFORM_VERSION")
 
 repositories {

diff --git a/platform-tooling-support-tests/projects/vintage/build.gradle.kts b/platform-tooling-support-tests/projects/vintage/build.gradle.kts
@@ -18,6 +18,9 @@ dependencies {
 		exclude(group = "junit")
 		because("we want to override it to test against different versions")
 	}
+
+	val platformVersion: String = System.getenv("JUNIT_PLATFORM_VERSION")
+	testRuntimeOnly("org.junit.platform:junit-platform-launcher:$platformVersion")
 }
 
 tasks.test {