Move @TestFactory return type validation to IsTestFactoryMethod

[sbrannen]

Overview

IsTestMethod and IsTestTemplateMethod currently validate that @Test and @TestTemplate methods have a void return type; however, IsTestFactoryMethod only validates that @TestFactory methods do not have a void return type. Consequently, @TestFactory return types are not validated during the discovery phase.

On the other hand, @TestFactory return types are in fact validated during the execution phase, but this is late and inconsistent with the behavior for all other types of testable methods.

Related Issues

• Introduce error handling mechanism for validation and discovery errors #242
• Forbid return values from test and lifecycle methods #835

Deliverables

• Move @TestFactory method return type validation from TestFactoryTestDescriptor to IsTestFactoryMethod.
• Enable @Disabled tests in IsTestFactoryMethodTests.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.

[stale]

This issue has been automatically closed due to inactivity. If you have a good use case for this feature, please feel free to reopen the issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.

[stale]

Closing due to lack of requested feedback. If you would like to proceed with your contribution, please provide the requested information and we will re-open this issue.