Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquire global read lock in presence of other exclusive resources #2614

Merged
merged 1 commit into from
May 15, 2021

Conversation

marcphilipp
Copy link
Member

Prior to this commit, the global read lock was not acquired for test
classes with @ResourceLock annotations causing @Isolated tests to
run in parallel.

Fixes #2605.

@marcphilipp marcphilipp requested a review from leonard84 May 13, 2021 16:23
@marcphilipp marcphilipp self-assigned this May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #2614 (83ea9a3) into main (05414dc) will increase coverage by 4.95%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2614      +/-   ##
============================================
+ Coverage     73.68%   78.63%   +4.95%     
- Complexity     3841     4083     +242     
============================================
  Files           424      424              
  Lines         11877    11878       +1     
  Branches        919      920       +1     
============================================
+ Hits           8751     9340     +589     
+ Misses         2799     2151     -648     
- Partials        327      387      +60     
Impacted Files Coverage Δ Complexity Δ
...rm/engine/support/hierarchical/NodeTreeWalker.java 83.72% <75.00%> (+26.57%) 20.00 <2.00> (+9.00)
...atform/commons/support/HierarchyTraversalMode.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../legacy/xml/LegacyXmlReportGeneratingListener.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-15.00%)
...platform/reporting/legacy/xml/XmlReportWriter.java 0.00% <0.00%> (-89.02%) 0.00% <0.00%> (-51.00%)
...it/platform/commons/support/ReflectionSupport.java 23.52% <0.00%> (-76.48%) 4.00% <0.00%> (-9.00%)
...t/platform/reporting/legacy/xml/XmlReportData.java 41.50% <0.00%> (-56.61%) 5.00% <0.00%> (-16.00%)
...junit/platform/engine/EngineExecutionListener.java 33.33% <0.00%> (-50.01%) 2.00% <0.00%> (-3.00%)
.../junit/platform/commons/util/ClasspathScanner.java 63.46% <0.00%> (-23.08%) 24.00% <0.00%> (-8.00%)
...java/org/junit/platform/testkit/engine/Events.java 78.26% <0.00%> (-18.48%) 33.00% <0.00%> (-8.00%)
...r/core/OutcomeDelayingEngineExecutionListener.java 63.33% <0.00%> (-16.67%) 8.00% <0.00%> (-2.00%)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05414dc...83ea9a3. Read the comment docs.

Prior to this commit, the global read lock was not acquired for test
classes with `@ResourceLock` annotations causing `@Isolated` tests to
run in parallel.

Fixes #2605.
@marcphilipp marcphilipp force-pushed the marc/2605-fix-global-read-lock branch from bfa3794 to 83ea9a3 Compare May 13, 2021 17:24
@marcphilipp marcphilipp merged commit e6d74ab into main May 15, 2021
@marcphilipp marcphilipp deleted the marc/2605-fix-global-read-lock branch May 15, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Isolated annotation doesn't work properly when @ResourceLock annotations are also used
3 participants