Allow specifying ForkJoinPool saturate predicate #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the method getSaturatePredicate to the interface ParallelExecutionConfiguration. This allows a custom configuration to supply a predicate to handle the case where the ForkJoinPool has reached the maximum pool size but all threads are currently blocked. Add a constructor to DefaultParallelExecutionConfiguration allowing to speciy the predicate and modify the existing constructor to specify null for the predicate. Modify DefaultParallelExecutionConfigurationStrategyTests to check the saturate predicate value in the default and custom configurations. Issue: junit-team#2787
juliette-derancourt
previously requested changes
Dec 11, 2021
There was a problem hiding this comment.
Hello @klease, I made a few comments and launched the CI builds :)
documentation/src/docs/asciidoc/release-notes/release-notes-5.9.0-M1.adoc
Outdated
Show resolved
Hide resolved
...main/java/org/junit/platform/engine/support/hierarchical/ParallelExecutionConfiguration.java
Outdated
Show resolved
Hide resolved
...main/java/org/junit/platform/engine/support/hierarchical/ParallelExecutionConfiguration.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2792 +/- ##
=========================================
Coverage 91.30% 91.30%
- Complexity 4509 4510 +1
=========================================
Files 390 391 +1
Lines 10936 10937 +1
Branches 846 846
=========================================
+ Hits 9985 9986 +1
Misses 730 730
Partials 221 221
Continue to review full report at Codecov.
|
sbrannen
changed the title
marcphilipp
requested changes
Dec 18, 2021
...main/java/org/junit/platform/engine/support/hierarchical/ParallelExecutionConfiguration.java
Outdated
Show resolved
Hide resolved
...main/java/org/junit/platform/engine/support/hierarchical/ParallelExecutionConfiguration.java
Outdated
Show resolved
Hide resolved
...main/java/org/junit/platform/engine/support/hierarchical/ParallelExecutionConfiguration.java
Outdated
Show resolved
Hide resolved
...va/org/junit/platform/engine/support/hierarchical/DefaultParallelExecutionConfiguration.java
Outdated
Show resolved
Hide resolved
...main/java/org/junit/platform/engine/support/hierarchical/ParallelExecutionConfiguration.java
Show resolved
Hide resolved
...main/java/org/junit/platform/engine/support/hierarchical/ParallelExecutionConfiguration.java
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/release-notes/release-notes-5.9.0-M1.adoc
Outdated
Show resolved
Hide resolved
...platform/engine/support/hierarchical/DefaultParallelExecutionConfigurationStrategyTests.java
Outdated
Show resolved
Hide resolved
…9.0-M1.adoc Co-authored-by: Marc Philipp <[email protected]>
This was referenced Jan 2, 2022
|
Also helps to address following issue related to Java 17 changes to ForkJoinPool: https://stackoverflow.com/questions/69768534/why-does-java-17-throw-a-rejectedexecutionexception-when-adding-tasks-to-a-forkj |
…t to supply a custom implementation with the saturate predicate
|
All requested changes are now committed. |
marcphilipp
dismissed
juliette-derancourt’s stale review
Comments have been addressed.
marcphilipp
approved these changes
Apr 10, 2022
marcphilipp
changed the title
|
Thanks @marcphilipp! |
|
Thanks to you and sorry for the delay! |
2 tasks
2 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the method getSaturatePredicate to the interface ParallelExecutionConfiguration.
This allows a custom configuration to supply a predicate to handle the case
where the ForkJoinPool has reached the maximum pool size but all threads
are currently blocked.
Add a constructor to DefaultParallelExecutionConfiguration allowing to
speciy the predicate and modify the existing constructor to specify
null for the predicate.
Modify DefaultParallelExecutionConfigurationStrategyTests to check the
saturate predicate value in the default and custom configurations.
Issue: #2787
I hereby agree to the terms of the JUnit Contributor License Agreement.