Warn when deleting symlinks targeting locations outside temp dir

[marcphilipp]

Overview

Resolves #4303.

---

I hereby agree to the terms of the JUnit Contributor License Agreement.

---

Definition of Done

• There are no TODOs left in the code
• Method preconditions are checked and documented in the method's Javadoc
• Coding conventions (e.g. for logging) have been followed
• Change is covered by automated tests including corner cases, errors, and exception handling
• Public API has Javadoc and @API annotations
• Change is documented in the User Guide and Release Notes

[YongGoose]

It was an honor to review your code❕

It’s so clean that I only have one piece of feedback—and even that is just a minor code style improvement.

Great work!

[YongGoose]

Suggested change

	assertThat(listener.stream(Level.WARNING)).map(LogRecord::getMessage) //
	.contains(("Deleting symbolic link from location inside of temp dir (%s) "
	+ "to location outside of temp dir (%s) but not the target file/directory").formatted(
	symbolicLink, directoryOutsideTempDir));
	assertThat(listener.stream(Level.WARNING)) //
	.map(LogRecord::getMessage) //
	.contains(("Deleting symbolic link from location inside of temp dir (%s) "
	+ "to location outside of temp dir (%s) but not the target file/directory") //
	.formatted(symbolicLink, directoryOutsideTempDir));

This change looked a bit cleaner to me.
It's a very minor adjustment, so feel free to ignore it if you don’t think it’s necessary!

---

This is the change I’d like to make, but I’m not sure if it has been applied correctly... 😵‍💫
If you accept my change and it ends up failing at the check stage, I sincerely apologize..

[marcphilipp]

Done in 8c1d995