Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync up with graphql/express-graphql master branch #2

Merged
merged 177 commits into from
Aug 9, 2020

Conversation

junminstorage
Copy link
Owner

pull in all changes

kaelig and others added 30 commits March 12, 2018 21:08
…426)

* Extract formatErrorFn even when failed to parse params

* Extract 'resolveOptions' function
* Add context to the arguments of the extensions function

* Update the extensions function example in the read me to better reflect changes
…atErrorFn

* formatError is deprecated.
* customFormatErrorFn to replace formatError.
This PR allows providing your own `execute` function instead of the default one from the `graphql-js`.
It’s a small change that adds a lot of flexibility since you can wrap standard `execute` and it opens new possibilities for middlewares. 

Personally, I need it to proxy calls to 3rd-party APIs.
It’s an alternative to #253 but introduces less code and more flexible mechanism.
It’s very important for us as it will be the last change required to switch [graphql-faker](https://github.com/APIs-guru/graphql-faker) from custom forks of `graphql-js` and `graphql-express`.
@wincent @leebyron Can you please review it?
@junminstorage junminstorage merged commit fd2b2b3 into junminstorage:from-master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.