forked from graphql/express-graphql
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync up with graphql/express-graphql master branch #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…426) * Extract formatErrorFn even when failed to parse params * Extract 'resolveOptions' function
* Add context to the arguments of the extensions function * Update the extensions function example in the read me to better reflect changes
…atErrorFn * formatError is deprecated. * customFormatErrorFn to replace formatError.
This PR allows providing your own `execute` function instead of the default one from the `graphql-js`. It’s a small change that adds a lot of flexibility since you can wrap standard `execute` and it opens new possibilities for middlewares. Personally, I need it to proxy calls to 3rd-party APIs. It’s an alternative to #253 but introduces less code and more flexible mechanism. It’s very important for us as it will be the last change required to switch [graphql-faker](https://github.com/APIs-guru/graphql-faker) from custom forks of `graphql-js` and `graphql-express`. @wincent @leebyron Can you please review it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull in all changes