Layout options widgets #24
Conversation
| "\n", | ||
| "elk_app.transformer.css_classes = {\n", | ||
| " \"n1\": {\n", | ||
| " ElkNode: set([\"example-custom-class\"]),\n", |
There was a problem hiding this comment.
As discussed, using classes as keys kinds freaks me out...
There was a problem hiding this comment.
Created new issue to track #31.
| "- [🦌 ELK App 🚀](./03_App.ipynb)\n", | ||
| "- [🦌 Interactive ELK App 🕹️](./04_Interactive.ipynb)\n", | ||
| "- [🦌 Node Label Placement 🏷️](./100_node_label_placement.ipynb)\n", | ||
| "- [🦌 Text Sizer 📏](./101_text_sizer.ipynb)" |
There was a problem hiding this comment.
re #28: we could have a table of contents that we just import instead of keeping this up-to-date
| inline = T.Bool(default_value=False) | ||
|
|
||
| def _ui(self) -> List[W.Widget]: | ||
| cb = W.Checkbox(description="Inline Edge Labels") |
There was a problem hiding this comment.
Perhaps we hoist the description to a static on the class... or standardize on
class FooBarBaz(LayoutOptionWidget):
""" Foo Bar Baz
first you foo, then you bar in order to baz
"""
def _ui(self) -> List[W.Widget]:
cb = W.Checkbox(description=self.__doc__.splitlines()[0].trim())
|
Going to try out merging this into #27 and will do interactive review from there... |
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "l = ipyelk.nx.XELKTypedLayout()" |
There was a problem hiding this comment.
lowercase L is a singularly bad variable name, along with O
There was a problem hiding this comment.
fixed this and added some other minor wording cleanup to that example notebook. I created a followon issue for more examples and the importnb PR should be there.
|
From a code perspective, it looks fine, if somewhat hard to grasp... however, there's almost no way I'd be able to look at the docs and actually make one of these custom thingers work. I think refining a few, targeted examples, for e.g. the edge collapsing, would be helpful... linking to the source is fine. |
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "# 🦌 ELK Transformer 🤖\n", |
There was a problem hiding this comment.
Needs more descriptive title, and less copy-pasta...
#19
XELKTransformer networkx nodes.XELKTransformer networkx nodes.