🐛 Fix options key present with parts during JB 1 upgrade

[bryanwweber]

• typo: fix numberted -> numbered in TOCTreeOptions
• fix: allow options key in toc with parts

Closes #1796

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4900155

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[rowanc1]

🚀

[agoose77]

Brilliant catch!

[agoose77]

We definitely should loosen the strictness of TOC handling during upgrade. However, I think the proper solution is to do this in the validation step:

mystmd/packages/myst-cli/src/init/jupyter-book/toc.ts

Lines 172 to 176 in fad8f67

	const BookTOC = z.union([
	BookTOCBase.and(BookShorthandOuterSubtree),
	BookTOCBase.merge(BookHasOuterSubtrees).strict(),
	BookTOCBase.strict(),
	]);

I will circle around to this shortly.

[bryanwweber]

We definitely should loosen the strictness of TOC handling during upgrade. However, I think the proper solution is to do this in the validation step:

mystmd/packages/myst-cli/src/init/jupyter-book/toc.ts

Lines 172 to 176 in fad8f67

	const BookTOC = z.union([
	BookTOCBase.and(BookShorthandOuterSubtree),
	BookTOCBase.merge(BookHasOuterSubtrees).strict(),
	BookTOCBase.strict(),
	]);

I will circle around to this shortly.

Thanks! I'd written to Rowan on discord, I tried to find a way to get Zod to issue a warning, but it doesn't really support that: https://discord.com/channels/1083088970059096114/1177359316886503464/1331659677485891664