📦 Upgrade redux toolkit and other packages #890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanc1
force-pushed
the
feat/redux-version
branch
from
df1b67e to
aa624b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes using
myst-cliraises some cjs dependency issues that look like this:This is for both
@redux/toolkitanddocx. The former is totally resolved by upgrading to v2: reduxjs/redux-toolkit#3849 🙌docxis slightly less straightforward. They fixed some of the cjs issues with ~v8.3 but introduced some typing issues: dolanmiu/docx#2289 dolanmiu/docx#2365 - despite those issues being closed, there's no clear conclusion. To get around this, I added our owntypes/docx/index.d.tsfile. Not a great solution - next time we develop docx functionality, it won't be easy. But for now, the changes in this PR makemyst-climore usable!