-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make code extractors and replacements modular #321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bollwyvl
reviewed
Aug 24, 2020
IPython-SQL has a connection concept which can be set per each cell or via line magic. It would be nice to be able to extract it and pass it to the virtual document so that it can be passed on to the language server during document initialization. |
2 tasks
krassowski
changed the title
[wip] Make code extractors and replacements modular
Make code extractors and replacements modular
Aug 29, 2020
krassowski
commented
Aug 29, 2020
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small step towards #191. I would postpone any major refactor until the JupyterLab 3.0 with the pip-based extension system ships, which seems that could change how we plan things a bit.
Pros:
%%html --isolated
magic bug (thanks to new tests!)Cons:
Checklist
ILSPCodeExtractorsManager
tokenILSPCodeReplacementsManager
tokenjupyterlab-lsp:extractors-ipython
, scope extractors for IPython built-in magics and expressions onlyjupyterlab-lsp:extractors-rpy2
jupyterlab-lsp:extractors-ipython-sql
to support As a user I would like to Highlight my SQL code syntax in JupyterLab jupyterlab/jupyterlab#8879 (not an IPython built-in)Chores