Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code extractors and replacements modular #321

Merged
merged 9 commits into from
Aug 31, 2020

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Aug 22, 2020

This is a small step towards #191. I would postpone any major refactor until the JupyterLab 3.0 with the pip-based extension system ships, which seems that could change how we plan things a bit.

Pros:

  • makes the code organisation a bit more sane (so that the different IPython extensions are not mixed together),
  • fixes an %%html --isolated magic bug (thanks to new tests!)
  • adds support for extraction of SQL from %%sql magics
  • provides tentative tokens for extending the transclusions:
    • I am not sure if having two tokens (as implemented here) rather than one large "TransclusionsManager" is the way to go in the future; it is, however, the way to make some progress on a topic that no one wanted to tackle for some time and to reduce technical debt; we can change the API in the future.

Cons:

  • it introduces an interface which we already plan to evolve and possibly break

Checklist

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski krassowski marked this pull request as draft August 22, 2020 10:21
@krassowski
Copy link
Member Author

IPython-SQL has a connection concept which can be set per each cell or via line magic. It would be nice to be able to extract it and pass it to the virtual document so that it can be passed on to the language server during document initialization.

@krassowski krassowski changed the title [wip] Make code extractors and replacements modular Make code extractors and replacements modular Aug 29, 2020
@krassowski krassowski marked this pull request as ready for review August 31, 2020 10:18
@krassowski krassowski merged commit c4257b5 into features-refactor Aug 31, 2020
@krassowski krassowski deleted the transclusion-refactor branch December 13, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants