Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and dependencies to support Tornado 5.0 #278

Closed
kevin-bates opened this issue Mar 7, 2018 · 0 comments
Closed

Fix tests and dependencies to support Tornado 5.0 #278

kevin-bates opened this issue Mar 7, 2018 · 0 comments

Comments

@kevin-bates
Copy link
Member

Issue #276 was introduced to limit the Tornado version to less than 5.0 since we're nearing a release boundary. This issue exists so that we can properly address Tornado 5.0 changes.

As mentioned in the referenced issue, Enterprise Gateway appears to operate against Tornado 5.0 once various modules within the jupyter stack have also been upgraded (namely, pyzmq, jupyter_client and notebook). However, failures still occur running the unit tests due to the removal of the previously deprecated class LogTrapTestCase.

At brief glance, I suspect changes will be required relative to ExpectLog (the recommended replacement for LogTrapTestCase) and in some ioloop handling. Notebook PR #3398 might prove helpful in this respect as might changes relative to Notebook Issue #3023.

Whatever we do here, we should look at applying to Kernel Gateway as well - since we inherited their tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants