persist userid cookie when auth is disabled #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows unsetting auth
ensures stable userid for a given browser when auth is completely disabled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1076 +/- ##
==========================================
- Coverage 76.23% 76.22% -0.01%
==========================================
Files 63 63
Lines 8226 8228 +2
Branches 1636 1637 +1
==========================================
+ Hits 6271 6272 +1
- Misses 1548 1550 +2
+ Partials 407 406 -1 ☔ View full report in Codecov by Sentry. |
blink1073
approved these changes
Nov 18, 2022
davidbrochart
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Thanks @minrk, I checked that it fixes jupyterlab/jupyterlab#13432.
Zsailer
approved these changes
Nov 18, 2022
|
Thank you, Min, for the fixing this so quickly! |
|
Thanks for the fix Min! |
|
Thanks Min!
…On Fri, Nov 18, 2022 at 10:23 AM Carlos Herrero ***@***.***> wrote:
Thanks for the fix Min!
—
Reply to this email directly, view it on GitHub
<#1076 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGXUC7PIEBIYB5DUUEY73WI7CR3ANCNFSM6AAAAAASEICLQ4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Brian E. Granger
Senior Principal Technologist, AWS AI/ML ***@***.***)
On Leave - Professor of Physics and Data Science, Cal Poly
@ellisonbg on GitHub
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a stable anonymous user, persisted via cookie (just like a token login).
closes #1033