Backport PR #1162: Reapply preferred_dir fix, now with better backwards compatability #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…better backwards compatability
vidartf
commented
Jan 6, 2023
Comment on lines
72
to
77
| import inspect | ||
|
|
||
| if inspect.isawaitable(self.dir_exists): | ||
| dir_exists = run_sync(self.dir_exists)(value) | ||
| else: | ||
| dir_exists = self.dir_exists(value) |
There was a problem hiding this comment.
This conditional probably needs to be forward-ported again.
Codecov ReportBase: 71.42% // Head: 71.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 1.x #1167 +/- ##
==========================================
- Coverage 71.42% 71.39% -0.03%
==========================================
Files 62 62
Lines 7765 7806 +41
Branches 1537 1543 +6
==========================================
+ Hits 5546 5573 +27
- Misses 1831 1841 +10
- Partials 388 392 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
for more information, see https://pre-commit.ci
vidartf
commented
Jan 6, 2023
Co-authored-by: Vidar Tonaas Fauske <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #1162.