Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt more lint rules #1189

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Conversation

blink1073
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 80.29% // Head: 80.46% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (17a6783) compared to base (b6c1edb).
Patch coverage: 65.82% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
+ Coverage   80.29%   80.46%   +0.16%     
==========================================
  Files          68       68              
  Lines        8149     8117      -32     
  Branches     1605     1584      -21     
==========================================
- Hits         6543     6531      -12     
+ Misses       1181     1172       -9     
+ Partials      425      414      -11     
Impacted Files Coverage Δ
jupyter_server/auth/__main__.py 0.00% <0.00%> (ø)
jupyter_server/i18n/__init__.py 44.23% <0.00%> (+1.63%) ⬆️
jupyter_server/services/kernels/connection/base.py 73.25% <0.00%> (ø)
...ter_server/services/kernels/connection/channels.py 62.16% <0.00%> (+0.05%) ⬆️
jupyter_server/utils.py 85.46% <0.00%> (ø)
jupyter_server/gateway/managers.py 83.60% <33.33%> (+0.19%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 81.81% <41.66%> (+0.24%) ⬆️
jupyter_server/gateway/gateway_client.py 78.52% <44.44%> (+0.71%) ⬆️
jupyter_server/traittypes.py 62.90% <50.00%> (-0.52%) ⬇️
jupyter_server/serverapp.py 80.21% <80.00%> (+0.37%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit beb0d45 into jupyter-server:main Feb 1, 2023
@blink1073 blink1073 deleted the adopt-more-ruff branch February 1, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant