Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application exit #384

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Fix application exit #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions jupyter_server/extension/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from tornado.log import LogFormatter
from tornado.web import RedirectHandler

from jupyter_core.application import JupyterApp
from jupyter_core.application import JupyterApp, NoStart

from jupyter_server.serverapp import ServerApp
from jupyter_server.transutils import _
Expand Down Expand Up @@ -501,4 +501,7 @@ def launch_instance(cls, argv=None, **kwargs):
"{ext_name} is running without loading "
"other extensions.".format(ext_name=cls.name)
)
serverapp.start()
try:
serverapp.start()
except NoStart:
pass