Re-use ServerApp.config_file_paths for consistency #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This property in the base class already has the same logic to add config_dir to jupyter_config_path JupyterHub overrides this to have slightly different logic, and the same should apply here
minrk
force-pushed
the
server_extension_paths
branch
from
aa1003b to
c19aad8
Compare
Codecov Report
@@ Coverage Diff @@
## main #715 +/- ##
==========================================
- Coverage 70.84% 70.82% -0.02%
==========================================
Files 62 62
Lines 7490 7486 -4
Branches 1187 1186 -1
==========================================
- Hits 5306 5302 -4
Misses 1829 1829
Partials 355 355
Continue to review full report at Codecov.
|
minrk
changed the title
base ServerApp should have total control over config file loading
minrk
changed the title
minrk
changed the title
Zsailer
approved these changes
Mar 10, 2022
|
Thanks, @minrk! Test failures appear unrelated. |
blink1073
added a commit
to blink1073/jupyter_server
that referenced
this pull request
Mar 14, 2022
…erver#715)" This reverts commit 653740c.
blink1073
added a commit
that referenced
this pull request
Mar 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than duplicating its logic, re-use the value. JupyterHub overrides this in the base ServerApp (jupyterhub/jupyterhub#3804), but the overridden value should be used for both: