make 'cwd' param for TerminalManager absolute #749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for jupyterlab/jupyterlab#12250 as discussed with @fcollonval
I was also thinking about a test. If here https://github.com/jupyter-server/jupyter_server/blob/main/tests/test_terminal.py#L83 I put
str(os.path.basename(terminal_path))
then the test 'hangs' (as expected, but it's not ideal in the test). Otherwise we can check forstr(terminal_path)
instead ofos.path.basename
here https://github.com/jupyter-server/jupyter_server/blob/main/tests/test_terminal.py#L136