Add back support for kernel launch timeout pad #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Jul 6, 2022
There was a problem hiding this comment.
This looks good @CiprianAnton. I had more comments than I anticipated, none of which are critical.
Co-authored-by: Kevin Bates <[email protected]>
- Update pad_timeout default value - Rename kernel_launch_timeout_pad => launch_timeout_pad
Codecov Report
@@ Coverage Diff @@
## main #910 +/- ##
==========================================
+ Coverage 71.44% 71.51% +0.06%
==========================================
Files 65 65
Lines 7705 7712 +7
Branches 1289 1289
==========================================
+ Hits 5505 5515 +10
+ Misses 1805 1804 -1
+ Partials 395 393 -2
Continue to review full report at Codecov.
|
kevin-bates
reviewed
Jul 6, 2022
Co-authored-by: Kevin Bates <[email protected]>
…s defined in this file
for more information, see https://pre-commit.ci
…of github.com:CiprianAnton/jupyter_server into users/canton/add-suport-for-kernel-launch-timeout-pad
kevin-bates
approved these changes
Jul 7, 2022
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter_server
that referenced
this pull request
Jul 7, 2022
blink1073
pushed a commit
that referenced
this pull request
Jul 7, 2022
…meout pad) (#911) Co-authored-by: Ciprian Anton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add support removed in 573adc3