Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #981: Make it easier to pass custom env variables to kernel #994

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

divyansshhh
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Base: 71.43% // Head: 71.52% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (ba2f17f) compared to base (507c697).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x     #994      +/-   ##
==========================================
+ Coverage   71.43%   71.52%   +0.08%     
==========================================
  Files          62       62              
  Lines        7738     7741       +3     
  Branches     1286     1283       -3     
==========================================
+ Hits         5528     5537       +9     
+ Misses       1821     1813       -8     
- Partials      389      391       +2     
Impacted Files Coverage Δ
jupyter_server/services/sessions/sessionmanager.py 88.47% <100.00%> (+0.16%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 80.58% <0.00%> (+1.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073
Copy link
Contributor

Thanks!

@blink1073 blink1073 merged commit f8e122b into jupyter-server:1.x Sep 26, 2022
@kevin-bates
Copy link
Member

Thanks @divyansshhh and @blink1073!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants