Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript widget toolkit without jquery #140

Closed
SylvainCorlay opened this issue Aug 10, 2015 · 9 comments
Closed

JavaScript widget toolkit without jquery #140

SylvainCorlay opened this issue Aug 10, 2015 · 9 comments
Labels
discussion resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@SylvainCorlay
Copy link
Member

The IPython widgets framework allows for other backbone view types than the usual JQuery-based, and neither widget.js nor manager.js really depends on JQuery.

However, we still use bootstrap and JQuery for the core basic IPython widgets like button / slider / date picker, dropdown.

I was wondering what is the best JavaScript widget framework that we could use as a replacement, and that would play well with phosphor. I am not sure if it is in the scope of phosphor to reimplement those. Apparently, it is possible to use bootstrap's css without the JQuery extension. There are replacements to this extension such as https://github.com/tagawa/bootstrap-without-jquery

What do you guys think about it?

@SylvainCorlay
Copy link
Member Author

@sccolbert @jdfreder this discussion could probably apply to other pieces of the front-end.

@sccolbert
Copy link

I'm busy refactoring Phosphor so that it can provide that type of leaf content. i.e. buttons, sliders, etc.. are now on the radar.

@SylvainCorlay
Copy link
Member Author

As part of phosphor, or would you prefer using something like bootstrap?

@sccolbert
Copy link

As part of phosphor. But as usual, nothing would prevent you from using bootstrap with a phosphor widget if you wanted to.

@SylvainCorlay
Copy link
Member Author

I would probably prefer using only one solution, and therefore use phosphor's basic widgets (however it is not here yet).
Besides the widgets repo should probably work with both the new and the old front-end for some time, and depending on phosphor would also help for other things like the signaling PR...

@ellisonbg
Copy link
Member

I think we should aim to have the interactive widgets be exactly the same
as we use elsewhere in our frontend UI. IOW, we shouldn't have two
different ButtonView (one for interactive widgets and another for our UI).
The two may and will be plugged into different models underneath, but that
is a separate issue.

I am +1 on not using jquery, although I think we are still using some of
the things from jquery.ui.

Bootstrap is still a pretty nice way of handling common UI elements. We
could roll our own, but would end up reinventing bootstrap in the process.

One option is to offer phosphor views that are simply wrappers around
bootstrap styled things.

I also think we should think carefully about scope limiting phosphor. I am
hesitant for it to start including all possible views needed to build
complex UIs. I think the messaging should be more around phosphor being the
foundation for building such things. That does raise the question about
what to do about the tab/panel layout stuff though.

Some of this does depend on how Chris's refactoring turns out.

On Mon, Aug 10, 2015 at 10:52 AM, Sylvain Corlay [email protected]
wrote:

I would probably prefer using only one solution, and therefore use
phosphor's basic widgets (however it is not here yet).
Besides the widgets repo should probably work with both the new and the
old front-end for some time, and depending on phosphor would also help for
other things like the signaling...


Reply to this email directly or view it on GitHub
#140 (comment).

Brian E. Granger
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]

@sccolbert
Copy link

As an fyi - I'm happy with the way the refactoring is turning out.

@jdfreder jdfreder modified the milestone: 4.1 Aug 21, 2015
@jdfreder jdfreder modified the milestones: 5.0, 4.1.0 Oct 14, 2015
@jdfreder
Copy link
Contributor

👍 to some incarnation of jquery-free backbone widgets. Marking as 5.0 because this definitely will be backwards incompatible. 👎 to the idea of dropping bootstrap for 5.0 and/or trying to ship our own jquery-less bootstrap, I don't think it's worth the effort. Maybe a later major release though...

@minrk minrk modified the milestones: 5.0, 5.1 Apr 21, 2016
@jasongrout
Copy link
Member

The current master now has rewritten widgets that don't use jquery, except for the slider. I've opened #630 for that.

@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

6 participants