-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix build errors #1430
[WIP] Fix build errors #1430
Conversation
The JQuery type definition has changed to disallow `import * as $ from 'jquery'`. Now the only ways of importing jquery are: const $ = require('jquery') // uses the exported module 'jquery' import 'jquery' // uses the global exports, which injects $ into the global namespace This commit chooses the latter to conform more closely to how other modules are imported.
I cannot install ipywidgets at all, also not previous versions. I'll try this fix. |
This indicates this will be fixed soon: DefinitelyTyped/DefinitelyTyped@844920f#commitcomment-22611629 |
The import errors are fixed. If you want to remove your import changes, I'll merge - the es2015.iterable changes still look needed. |
Ah thanks for checking! I'll do this now. |
A prior commit introduced a global import of jquery to fix a temporary problem in types. Now not needed.
I added the same fix to jupyter-widgets-base. Thanks! |
As far as I can tell, master has stopped building correctly due to a dependency update (related to this?). This is (probably) only visible off a fresh clone, or at least removing the node_modules in jupyter-widgets-controls. It also occurred on PR #1410.
I think this is due to an update in the type defintions for JQuery. The module definition now reads:
This means that the only ways of importing jquery are:
In particular, we were importing jQuery using
import * as $ from 'jquery'
, which is now not allowed.This is still fairly broken on Travis.